Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct output dimension for ts.pair_coalescence_counts with extra time windows #3058

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

nspope
Copy link
Contributor

@nspope nspope commented Nov 19, 2024

Fixes #3046

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (9acedd2) to head (b99dfe7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3058   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          29       29           
  Lines       32128    32137    +9     
  Branches     5763     5765    +2     
=======================================
+ Hits        28868    28877    +9     
  Misses       1859     1859           
  Partials     1401     1401           
Flag Coverage Δ
c-tests 86.69% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.05% <ø> (ø)
python-tests 98.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/trees.py 98.80% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@nspope
Copy link
Contributor Author

nspope commented Nov 20, 2024

Shall we merge this, then I'll rebase #3059 and update the changelog?

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 20, 2024
@nspope
Copy link
Contributor Author

nspope commented Nov 20, 2024

mergify issues again:

nspope does not have write access to the forked repository.

@jeromekelleher jeromekelleher merged commit b31d4d1 into tskit-dev:main Nov 20, 2024
19 of 21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts.pair_coalescence_counts truncates output array dimension to last time window with a node
2 participants