Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature sql fragments #113

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Feature sql fragments #113

wants to merge 3 commits into from

Conversation

Newbie012
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2023

⚠️ No Changeset found

Latest commit: 8e836e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
safeql ⬜️ Ignored (Inspect) Jan 8, 2023 at 5:58PM (UTC)

@sds
Copy link

sds commented Dec 23, 2024

Hey @Newbie012—noticed that your recent roadmap post didn't mention fragments support.

Did you run into a blocker when implementing this? Being able to compose SQL from multiple fragments would be incredibly useful in DRYing up code.

Curious if you had any thoughts on the feature in general. Would you be opposed to an outside contribution adding support for fragments?

Thanks!

@Newbie012
Copy link
Collaborator Author

Hi @sds,

When I first drafted this PR, I realized it would be too difficult to support sql fragments while still keeping SafeQL library-agnostic (since each library has its own implementation, and I didn't want to force any convention).

Although I haven’t explicitly mentioned SQL fragments in the roadmap, I plan to address them using [custom presets](https://safeql.dev/blog/safeql-v4-roadmap.html#example-3-custom-library-presets).

These presets will provide the low-level control needed to support SQL fragments while still allowing SafeQL’s core to remain library-agnostic and pluggable.

@sds
Copy link

sds commented Dec 24, 2024

Thanks for the response! Looking forward to v4 when it's ready—thanks for all your work on SafeQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants