[feat] Add an ability to import permissions, source control and sso resources #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2024 16:49
ph-ph
commented
Aug 19, 2024
| @@ -125,7 +125,7 @@ func TestMain(m *testing.M) { | |||
| resource.TestMain(m) | |||
| } | |||
|
|
|||
| func TestAccSourceControl(t *testing.T) { | |||
| func TestAccSourceControlTest(t *testing.T) { | |||
There was a problem hiding this comment.
Had to add ...Test in the end - otherwise, this test's name is a prefix for TestAccSourceControlSettings, and I couldn't run this test in isolation - go test would always run both, which is annoying.
ph-ph
commented
Aug 19, 2024
| @@ -37,8 +37,7 @@ func main() { | |||
| flag.Parse() | |||
|
|
|||
| opts := providerserver.ServeOpts{ | |||
| // TODO(dzmitry.kishylau): Update this string with the published name of Retool provider. | |||
| Address: "registry.terraform.io/retool/retool", | |||
| Address: "registry.terraform.io/tryretool/retool", | |||
There was a problem hiding this comment.
Tbh, not sure what this string does exactly, but changing it to tryretool/retool breaks local dev for unknown reasons.
albertchang
approved these changes
Aug 21, 2024
Co-authored-by: Albert Chang <[email protected]>
Co-authored-by: Albert Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At first, I didn't implement import support for resources that don't have straightforward "id". But being able to import them is actually pretty useful, given that it makes it possible to use generate configuration function of Terraform.
This change adds
ImportStatemethod to resources that don't have it yet. In most cases, we don't care about import id, but forpermissionsresource we use subject to identify it.Tests
Updated acceptance tests and re-recorded requests.