refactor(vm): Refactor simple object patterns #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch prepares object patterns to be split into simple and complex similarly to array patterns (see trynova#394), where complex patterns (having either initializers or computed property keys) would be transpiled into regular bytecode. Since only a subset of simple object patterns were supported so far, this patch refines the compilation to only use two binding properties, `BindingPatternBind` and `BindingPatternBindNamed`. In the future, rest bindings will also be supported. Despite being a refactoring, this patch makes certain tests pass due to bugs in the original implementation of object patterns.
This was referenced Aug 24, 2024
aapoalas
previously approved these changes
Aug 25, 2024
aapoalas
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prepares object patterns to be split into simple and complex similarly to array patterns (see #394), where complex patterns (having either initializers or computed property keys) would be transpiled into regular bytecode.
Since only a subset of simple object patterns were supported so far, this patch refines the compilation to only use two binding properties,
BindingPatternBindandBindingPatternBindNamed. In the future, rest bindings will also be supported.Despite being a refactoring, this patch makes certain tests pass due to bugs in the original implementation of object patterns.