-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Polymesh chain from Polkadot impl. #4229
Open
Neopallium
wants to merge
22
commits into
trustwallet:master
Choose a base branch
from
PolymeshAssociation:polymesh_rust_impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Split Polymesh chain from Polkadot impl. #4229
Neopallium
wants to merge
22
commits into
trustwallet:master
from
PolymeshAssociation:polymesh_rust_impl
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split Polymesh support out of the Polkadot Rust impl into its own crate and fix permissions encoding.
How to test
Run Rust, C++, iOS, Android tests.
Types of changes
ToScale
support forString
,BTreeSet
,BTreeMap
.impl_enum_scale
enums to re-use the same variant index for multiple variants, to support backwards/forwards compatibility (the spec/transaction versions can be used to encode the correct variant).Checklist
If you're adding a new blockchain