Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): issuer acknowledgment #684

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat(sdk): issuer acknowledgment #684

merged 1 commit into from
Nov 28, 2023

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Nov 28, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (77e6e95) 89.10% compared to head (7fbe8b4) 89.01%.

Files Patch % Lines
pkg/openid4ci/interaction.go 73.91% 6 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   89.10%   89.01%   -0.10%     
==========================================
  Files         103      103              
  Lines        4150     4216      +66     
==========================================
+ Hits         3698     3753      +55     
- Misses        308      312       +4     
- Partials      144      151       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkubiv vkubiv changed the title Feat issuer acknowledgment feat(sdk): issuer acknowledgment Nov 28, 2023
@vkubiv
feat(sdk): issuer acknowledgment.
7fbe8b4 
Signed-off-by: Volodymyr Kubiv <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.7% 10.7% Duplication

@rolsonquadras rolsonquadras merged commit 2e48050 into trustbloc:main Nov 28, 2023
@vkubiv vkubiv deleted the feat-issuer-acknowledgment branch December 11, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolsonquadras rolsonquadras rolsonquadras approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkubiv @codecov-commenter @rolsonquadras