State adapt #51
Open
State adapt #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and I had to turn on |
|
Here's a YouTube video I made while refactoring this https://www.youtube.com/watch?v=sUfahKhzZzc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of #50
But this should build because it removes Akita. Unless something else is wrong.
I originally didn't plan on creating a PR, so I have some changes in here you may not like. I got rid of
_variable prefixes, for example.There were a few places I needed to synchronously access state, which I handled with a quick hack using
take(1)).subscribe(. For me to get rid of these, I would have to refactor the components too, not just the stores. This could be a fun project, making the whole thing 100% reactive. I could use signals too, where I think it makes sense.For now I am just updating with these PRs over in my fork, so I thought I'd share in case you wanted anything.