Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-126760 / 13.3 / Disable autocomplete for user and password inputs on disk edit #9855

Closed
wants to merge 1 commit into from
Closed

NAS-126760 / 13.3 / Disable autocomplete for user and password inputs on disk edit #9855

wants to merge 1 commit into from

Conversation

RehanY147
Copy link
Contributor

No description provided.

@RehanY147 RehanY147 requested a review from a team as a code owner March 20, 2024 15:01
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team March 20, 2024 15:01
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-126760

@bugclerk bugclerk changed the title Disable autocomplete for user and password inputs on disk edit NAS-126760 / 13.3 / Disable autocomplete for user and password inputs on disk edit Mar 20, 2024
@AlexKarpov98
Copy link
Contributor

@RehanY147 - does it fix the original issue?

AlexKarpov98
AlexKarpov98 reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it's fixing the original issue.
I tried without your changes - it works fine for me (same as with your changes)

How did you reproduce the original issue?

As well I get compilation error:

Screenshot 2024-03-20 at 18 11 45

@RehanY147
Copy link
Contributor Author

This issue seems to be unrelated to what the UI is doing. Will creating another PR

@RehanY147 RehanY147 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RehanY147 @bugclerk @AlexKarpov98