Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-125844 / 13.0 / Javascript error trying to edit disk in web UI #9461

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

bvasilenko
Copy link
Contributor

Testing

  1. On a machine with Core,
  2. Go to Storage -> Pools -> Pool status
  • Option A. have a pool of type Mirror (2 disks)
  • Option B. mock pool.query and disk.query with the ticket's JSON files
  1. Choose /dev/xxx > (Tri-Dot Menu) > Edit (see image below)

    image

    Expected result: Edit action takes the user to Edit form, and console has no error

  2. Try other actions

    • Offline
    • Replace
    • Detach
    • Remove

    Expected result: user is taken to the corresponding form.

@bvasilenko bvasilenko requested a review from a team as a code owner January 17, 2024 13:37
@bvasilenko bvasilenko requested review from AlexKarpov98 and removed request for a team January 17, 2024 13:37
@bugclerk bugclerk changed the title Javascript error trying to edit disk in web UI NAS-125844 / 13.0 / Javascript error trying to edit disk in web UI Jan 17, 2024
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvasilenko - can you tell me on which u13 remote machine I can test it?

@bvasilenko
Copy link
Contributor Author

@AlexKarpov98 I don't have a suitable machine at the moment

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good, I don't get any error.

@undsoft undsoft merged commit c9f63a2 into truenas/13.0-stable Jan 30, 2024
3 checks passed
@undsoft undsoft deleted the NAS-125844-13.0 branch January 30, 2024 13:03
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants