Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133621 / 25.04 / Bring back One Drive #11357

Merged
merged 4 commits into from
Jan 20, 2025
Merged

NAS-133621 / 25.04 / Bring back One Drive #11357

merged 4 commits into from
Jan 20, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 19, 2025

Changes:

Allows to use One Drive Cloud Sync provider.

Testing:

Note: I had MW issues with listing directories in cloud sync task once provider was added. I've created separate tickets for this.

Downstream

Affects Reasoning
Documentation Microsoft One Drive is back.

# Conflicts:
#	src/assets/i18n/es-ar.json
#	src/assets/i18n/ko.json
#	src/assets/i18n/zh-hans.json
@undsoft undsoft requested a review from a team as a code owner January 19, 2025 20:38
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team January 19, 2025 20:38
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-133621: Bring back One Drive NAS-133621 / 25.04 / Bring back One Drive Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (8883779) to head (9b619b1).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...provider-form/one-drive-provider-form.component.ts 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11357      +/-   ##
==========================================
+ Coverage   82.86%   82.87%   +0.01%     
==========================================
  Files        1665     1666       +1     
  Lines       59599    59659      +60     
  Branches     6258     6262       +4     
==========================================
+ Hits        49386    49444      +58     
- Misses      10213    10215       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/assets/i18n/es-ar.json
#	src/assets/i18n/ko.json
#	src/assets/i18n/zh-hans.json
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Drive is back. 👍

@undsoft undsoft merged commit c2e5fbc into master Jan 20, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133621 branch January 20, 2025 22:19
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants