-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132261 / 25.04 / Setup Truenas Connect integration #11355
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11355 +/- ##
========================================
Coverage 82.85% 82.86%
========================================
Files 1660 1665 +5
Lines 59414 59582 +168
Branches 6241 6250 +9
========================================
+ Hits 49226 49370 +144
- Misses 10188 10212 +24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing:
midclt call tn_connect.update '{ "enabled": true, "ips": [ {{ NAS_IP }} ], "account_service_base_url": "https://account-service.dev.ixsystems.net/", "leca_service_base_url": "https://leca-server.dev.ixsystems.net/", "tnc_base_url": "https://truenas.connect.dev.ixsystems.net/"}'
results in
[EINVAL] tn_connect_update: Input should be a valid dictionary or instance of TNCUpdateArgs
for me.
...odules/truenas-connect/components/truenas-connect-modal/truenas-connect-modal.component.html
Outdated
Show resolved
Hide resolved
.../modules/truenas-connect/components/truenas-connect-modal/truenas-connect-modal.component.ts
Outdated
Show resolved
Hide resolved
.../modules/truenas-connect/components/truenas-connect-modal/truenas-connect-modal.component.ts
Outdated
Show resolved
Hide resolved
.../modules/truenas-connect/components/truenas-connect-modal/truenas-connect-modal.component.ts
Show resolved
Hide resolved
src/app/modules/truenas-connect/services/truenas-connect.service.ts
Outdated
Show resolved
Hide resolved
@undsoft make sure to provide ip address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some issues where connection status only updated after I reloaded the page, but other than that it worked okay. I'm going to merge what we currently have and we can test some more later.
This PR has been merged and conversations have been locked. |
Changes:
Setup Truenas Connect integration
Testing:
midclt call tn_connect.update '{ "enabled": true, "ips": [ {{ NAS_IP }} ], "account_service_base_url": "https://account-service.dev.ixsystems.net/", "leca_service_base_url": "https://leca-server.dev.ixsystems.net/", "tnc_base_url": "https://truenas.connect.dev.ixsystems.net/"}'
generate token
Connect
button, and it opens a new tab for adding the system to TNCDownstream