NAS-133494 / 25.04 / WIP: Enclosure Colors

[dszidi]

Changes:

Changes how we apply color coding to

Testing:

Use mock enclosure utility and test for models M60, ES24, ES24F, MINI-R, H-Series, X-Series, ES12, ES102G2. These models were chosen to show a variety of different layouts and drive tray types. Once this PR is approved the other models will be updated.

Downstream

This only touches the enclosure-svg component files and the SVG assets themselves. Assets are updated with some class selectors and CSS. Nothing else should be affected.

This will affect documentation as screen shots of the enclosure visualization will look different now.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133494

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (fdda7b3) to head (0c888a7).
Report is 25 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...sure-side/enclosure-svg/enclosure-svg.component.ts	61.53%	15 Missing ⚠️

❌ Your patch check has failed because the patch coverage (61.53%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11345      +/-   ##
==========================================
+ Coverage   82.92%   82.93%   +0.01%     
==========================================
  Files        1666     1669       +3     
  Lines       59715    59947     +232     
  Branches     6276     6303      +27     
==========================================
+ Hits        49516    49717     +201     
- Misses      10199    10230      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

Overall looks nice, thank you.
Let's clean up some things in code.

[undsoft]

I would suggest updating code that initially looks for drives cages in processSvg to store them as class properties and then using that here and below.

[dszidi]

@undsoft Updated the file. Please check again.

[undsoft]

Something is wrong now.

1. Rear slots on M60 are incorrect.
2. Front slots on R20 are incorrect.

[dszidi]

Something is wrong now.

1. Rear slots on M60 are incorrect.
2. Front slots on R20 are incorrect.

I reverted the change. R20 is not on the list of updated enclosures for this PR. I only did a cross section of models for review purposes. I will update the others in a separate PR once this gets merged

[undsoft]

So, why not forward fix it? We still need to make code updates.

[undsoft]

Some models, including but not limited to R20, ES24N, ES60, ES102 are broken compared to master.

[dszidi]

Rackmount models are done. Only the Desktop MINIs should be left