Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133299 / 24.10.2 / Extend window not showing up for spares #11303

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 7, 2025

Testing:

  1. Replace ws.service.ts with attached file.
    ws.service.ts.txt
  2. Navigate to /storage/3/devices/ and test that cards open. Functionality will be limited because of the mock
    , but there should not be console errors.

@undsoft undsoft added the backport-25.04-RC.1 Fangtooth RC1 label Jan 7, 2025
@undsoft undsoft requested a review from a team as a code owner January 7, 2025 23:33
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team January 7, 2025 23:33
@bugclerk bugclerk changed the title NAS-133299: Extend window not showing up for spares NAS-133299 / 24.10.2 / Extend window not showing up for spares Jan 7, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Jan 7, 2025

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@6ba7381). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...disk-details-panel/disk-details-panel.component.ts 0.00% 1 Missing ⚠️
...idz-extend-dialog/raidz-extend-dialog.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11303   +/-   ##
=====================================================
  Coverage                      ?   80.01%           
=====================================================
  Files                         ?     1574           
  Lines                         ?    51517           
  Branches                      ?     5947           
=====================================================
  Hits                          ?    41220           
  Misses                        ?    10297           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@undsoft undsoft merged commit 41e9bb2 into stable/electriceel Jan 8, 2025
6 of 7 checks passed
@undsoft undsoft deleted the NAS-133299 branch January 8, 2025 14:38
@bugclerk
Copy link
Contributor

bugclerk commented Jan 8, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants