Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133383 / 25.04 / Expose checkbox to enable GPOS STIG #11291

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Changes:

Testing:
See ticket.
result:
Screenshot 2025-01-06 at 14 09 39
Screenshot 2025-01-06 at 14 09 45

Downstream

Affects Reasoning
Documentation New System Security Option

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 6, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 6, 2025 12:12
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team January 6, 2025 12:12
@bugclerk bugclerk changed the title NAS-133383: Expose checkbox to enable GPOS STIG NAS-133383 / 25.04 / Expose checkbox to enable GPOS STIG Jan 6, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (75e4f06) to head (66b9227).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/modules/auth/auth.service.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11291      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.01%     
==========================================
  Files        1654     1654              
  Lines       59122    59129       +7     
  Branches     6209     6209              
==========================================
+ Hits        48925    48926       +1     
- Misses      10197    10203       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI issues:

  1. The whole system security card is under a system.security.info.fips_available check, so you can remove additional checks for enterprise license.
  2. Once STIG is enabled, you get stuck in the infinite loop that shows "[ENOTSUP] TOKEN_PLAIN: mechanism is not supported at current authenticator level.".
    We'll make more fixes in another ticket, but for this ticket let's at least clear token on token login errors, so that user doesn't end up in an infinite loop.

@AlexKarpov98
Copy link
Contributor Author

@undsoft

Fixed.

Screen.Recording.2025-01-07.at.14.23.44.mov

@AlexKarpov98 AlexKarpov98 requested a review from undsoft January 7, 2025 12:37
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for this ticket.

@AlexKarpov98 AlexKarpov98 merged commit 7619f19 into master Jan 9, 2025
10 of 11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133383 branch January 9, 2025 07:56
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants