-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133383 / 25.04 / Expose checkbox to enable GPOS STIG #11291
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11291 +/- ##
==========================================
- Coverage 82.75% 82.74% -0.01%
==========================================
Files 1654 1654
Lines 59122 59129 +7
Branches 6209 6209
==========================================
+ Hits 48925 48926 +1
- Misses 10197 10203 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI issues:
- The whole system security card is under a
system.security.info.fips_available
check, so you can remove additional checks for enterprise license. - Once STIG is enabled, you get stuck in the infinite loop that shows "[ENOTSUP] TOKEN_PLAIN: mechanism is not supported at current authenticator level.".
We'll make more fixes in another ticket, but for this ticket let's at least clear token on token login errors, so that user doesn't end up in an infinite loop.
Fixed. Screen.Recording.2025-01-07.at.14.23.44.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for this ticket.
This PR has been merged and conversations have been locked. |
Changes:
Testing:
See ticket.
result:
Downstream