Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133759 / 25.04 / Add missing await in sed_unlock_all #15470

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

bmeagherix
Copy link
Contributor

@bmeagherix bmeagherix commented Jan 23, 2025

Add missing await in sed_unlock_all. Seems to have been introduced in PR #15375

Noticed

/usr/lib/python3/dist-packages/middlewared/plugins/disk_/sed.py:85: RuntimeWarning: coroutin>

in systemctl status middlewared output.

Add an await.

@bugclerk bugclerk changed the title Add missing await in sed_unlock_all NAS-133759 / 25.04 / Add missing await in sed_unlock_all Jan 23, 2025
@bugclerk
Copy link
Contributor

@truenas truenas deleted a comment from bugclerk Jan 23, 2025
@bmeagherix bmeagherix requested a review from a team January 23, 2025 21:50
@bmeagherix bmeagherix merged commit b01abf8 into master Jan 23, 2025
2 checks passed
@bmeagherix bmeagherix deleted the fix_sed_unlock_all branch January 23, 2025 21:51
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants