NAS-132669 / 25.04 / Make parse_message ensure that the message is a dict

[themylogin]

The following traceback occurred when the message was []:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/aiohttp/web_protocol.py", line 477, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/aiohttp/web_app.py", line 559, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/aiohttp/web_middlewares.py", line 105, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/aiohttp/web_urldispatcher.py", line 210, in handler_wrapper
    result = await result
             ^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/middlewared/api/base/server/ws_handler/base.py", line 32, in __call__
    await self.process(origin, ws)
  File "/usr/lib/python3/dist-packages/middlewared/api/base/server/ws_handler/rpc.py", line 211, in process
    message = parse_message(app.authenticated, msg.data)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/middlewared/utils/limits.py", line 74, in parse_message
    if (method := message.get('method')) in MSG_SIZE_EXTENDED_METHODS:
                  ^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'get'

[themylogin]

time 1:00

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132669

[yocalebo]

While the attribute error is good to know, I'd rather indicate that JSON-RPC supports batch messages but we're not supporting that at the moment.

[yocalebo]

Thanks!

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.