Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-127348 / 24.10 / Add iSCSI test test_33_no_lun_zero #13693

Merged
merged 1 commit into from
May 9, 2024

Conversation

bmeagherix
Copy link
Contributor

Now that SCST will allow REPORT LUNS to operate on an unsupported LUN (PR #223, present in EE), we can add a test to that effect, by creating a target that does not have an extent on LUN 0.

In test_33_no_lun_zero create a target with LUN 100 and 101 instead.

Unfortunately libiscsi performs a TEST UNIT READY following a connect (which will fail), so we cannot use it to test connecting to a missing LUN 0.

Instead enhance (and call) the existing target_login_test utility, adding an optional check_surfaced_luns parameter. This will using the test runner OS utility (e.g. iscsiadm) to login the target, and then we will ensure that the expected LUNs are seen.


Tested with HA and SINGLE.

@bugclerk bugclerk changed the title Add iSCSI test test_33_no_lun_zero NAS-127348 / 24.10 / Add iSCSI test test_33_no_lun_zero May 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented May 9, 2024

@bmeagherix bmeagherix requested a review from a team May 9, 2024 16:25
@bmeagherix bmeagherix self-assigned this May 9, 2024
@bmeagherix bmeagherix merged commit eecaea0 into master May 9, 2024
2 of 3 checks passed
@bmeagherix bmeagherix deleted the NAS-127348 branch May 9, 2024 18:15
@bugclerk
Copy link
Contributor

bugclerk commented May 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants