Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130858 / 25.04 / remove file exclusion from ixdiagnose on enterprise systems #218

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

themylogin
Copy link
Contributor

No description provided.

@themylogin themylogin requested a review from a team August 30, 2024 10:22
@themylogin
Copy link
Contributor Author

time 1:30

@bugclerk bugclerk changed the title remove file exclusion from ixdiagnose on enterprise systems NAS-130858 / 25.04 / remove file exclusion from ixdiagnose on enterprise systems Aug 30, 2024
@bugclerk
Copy link

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.64%. Comparing base (a27b919) to head (3e698dc).

Files with missing lines Patch % Lines
ixdiagnose/plugins/system_state.py 16.66% 15 Missing ⚠️
ixdiagnose/utils/command.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   91.83%   91.64%   -0.19%     
==========================================
  Files         103      103              
  Lines        2314     2323       +9     
==========================================
+ Hits         2125     2129       +4     
- Misses        189      194       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themylogin themylogin merged commit 2ec4efb into master Aug 30, 2024
6 checks passed
@themylogin themylogin deleted the NAS-130858 branch August 30, 2024 11:32
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants