Grounding space implementation with a more compact representation in memory #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsbogd
changed the title
vsbogd
changed the title
vsbogd
force-pushed
the
grounding-space
branch
from
3ee3106 to
ea50584
Compare
Storage keeps hashable atoms and returns integer id as a key to the atom. Thus integer id can be used instead of atom inside space index.
Iterator which returns atoms and expression start/end for index.
Before this change such case was handled as a custom matching. Which means all atoms are extracted from index and matched with an atom from query. Now we represent this case as en exact matching which is not in the index. Thus only custom matchers for the specific branch of the index are applied.
Implement everything except removing atom. Also AtomIndex doesn't keep and return duplicated atom.
Rename AtomTokenIter to AtomIter, Exact to ExactId, AtomIndexNode to AtomTrieNode. Use Cow to represent both atom and reference to atom in AtomToken and thus allow moving atoms when inserting new atom into the index.
Do some renaming in code to make it more clear
Implement GroundingSpace::remove and GroundingSpace::replace methods.
VecOnDemand collection allocates real vector only on write operations.
vsbogd
force-pushed
the
grounding-space
branch
from
d1fa407 to
e8b9d9e
Compare
vsbogd
force-pushed
the
grounding-space
branch
from
ceee129 to
9a91f15
Compare
Use WithDuplication strategy as a default one for compatibility. Add unit tests to check both strategies work correctly.
Separate custom/exact matching mode and hashable/nonhashable store mode. Represent both mode in a trie key explicitly.
Rename some types and methods to make names more logical.
vsbogd
force-pushed
the
grounding-space
branch
from
9f1c172 to
cd00c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AtomStorageto represent symbols, variables and hashable grounded atoms as an integer number. AddAtomIndexto keep ids instead of atoms and unify during search via index tree. ReimplementGroundingSpaceusingAtomIndex. Allow user choosing whether atomspace keeps duplicates of atoms or not. Use keeping duplicates as a default strategy.