fix: listing table and columns were executed with null category because it specify database name instead of category name. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it specify database name instead of category name.
yas-okadatech
force-pushed
the
27783-catalog
branch
from
cb1d300 to
ff237d8
Compare
NamedPython
approved these changes
Oct 24, 2024
|
@yas-okadatech I would assume that this PR is an attempt to reduce the differences in the code, |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although getTables / getPrimaryKeys / getColumns expect catalog name, TableIdentifier::getDatabase() doesn't return catalog name. And getDatabase() returns null, so getTables, etc scan all catalogs unfortunatey.
In a user's environment, an error cropped up. So I need this fix.