Merge pull request #13 from trocco-io/feature/fix_ci_test

change secrets to vars and add NON_ASCII vars in github workflows
trocco-io · Dec 23, 2024 · f1e0f1b · f1e0f1b
2 parents f9dc1a0 + aea8642
commit f1e0f1b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -36,13 +36,15 @@ jobs:
       - name: Write test secret to file
         run: envsubst < ci/config_template.yml > test-config.yml
         env:
-          SERVER_HOSTNAME: ${{ secrets.TEST_SERVER_HOSTNAME }}
-          HTTP_PATH: ${{ secrets.TEST_HTTP_PATH }}
+          SERVER_HOSTNAME: ${{ vars.TEST_SERVER_HOSTNAME }}
+          HTTP_PATH: ${{ vars.TEST_HTTP_PATH }}
           PERSONAL_ACCESS_TOKEN: ${{ secrets.TEST_PERSONAL_ACCESS_TOKEN }}
-          CATALOG_NAME: ${{ secrets.TEST_CATALOG_NAME }}
-          SCHEMA_NAME: ${{ secrets.TEST_SCHEMA_NAME }}
-          TABLE_PREFIX: ${{ secrets.TEST_TABLE_PREFIX }}
-          STAGING_VOLUME_NAME_PREFIX: ${{ secrets.TEST_STAGING_VOLUME_NAME_PREFIX }}
+          CATALOG_NAME: ${{ vars.TEST_CATALOG_NAME }}
+          SCHEMA_NAME: ${{ vars.TEST_SCHEMA_NAME }}
+          TABLE_PREFIX: ${{ vars.TEST_TABLE_PREFIX }}
+          NON_ASCII_CATALOG_NAME: ${{ vars.TEST_NON_ASCII_CATALOG_NAME }}
+          NON_ASCII_SCHEMA_NAME: ${{ vars.TEST_NON_ASCII_SCHEMA_NAME }}
+          STAGING_VOLUME_NAME_PREFIX: ${{ vars.TEST_STAGING_VOLUME_NAME_PREFIX }}
       - run: ./gradlew test
         env:
           EMBULK_OUTPUT_DATABRICKS_TEST_CONFIG: "./test-config.yml"

diff --git a/ci/config_template.yml b/ci/config_template.yml
@@ -4,4 +4,6 @@ personal_access_token: "$PERSONAL_ACCESS_TOKEN"
 catalog_name: "$CATALOG_NAME"
 schema_name: "$SCHEMA_NAME"
 table_prefix: "$TABLE_PREFIX"
+non_ascii_catalog_name: "$NON_ASCII_CATALOG_NAME"
+non_ascii_schema_name: "$NON_ASCII_SCHEMA_NAME"
 staging_volume_name_prefix: "$STAGING_VOLUME_NAME_PREFIX"