Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DartSass-Sprockets compilation errors in production ENV. #471

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

seanaery
Copy link
Collaborator

  • Adds a temporary shim to patch a BL core bug where breakpoint-max(xs) was used
  • Removes the default blacklight.scss file that the BL assets generator creates, since... we import those files already in trln_argon_dependencies.scss; duplicates cause problems
  • Specifies the pre-compiled chosen.css for import from trln-chosen-rails, so chosen.scss is not used

- Adds a temporary shim to patch a BL core bug where breakpoint-max(xs) was used
- Removes the default blacklight.scss file that the BL assets generator creates, since...
  we import those files already in trln_argon_dependencies.scss; duplicates cause problems
- Specifies the pre-compiled chosen.css for import from trln-chosen-rails, so chosen.scss is not used
@adjam adjam merged commit 4c4ef67 into Blacklight-8 Nov 19, 2024
8 checks passed
seanaery added a commit that referenced this pull request Dec 4, 2024


- BL core invalid CSS bug making this necessary has now been fixed in 8.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants