Skip to content

Commit

Permalink
Update blacklight_range_limit to v9.0.0.beta2
Browse files Browse the repository at this point in the history
- removes hack from #473 to skip the JS installer; beta2 now supports --skip-assets option
  • Loading branch information
seanaery committed Dec 4, 2024
1 parent 9690e04 commit ea5c143
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
15 changes: 0 additions & 15 deletions lib/generators/blacklight_range_limit/assets_generator.rb

This file was deleted.

6 changes: 2 additions & 4 deletions lib/generators/trln_argon/install_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ def run_dependency_generators
say_status('info', 'Installing Blacklight Range Limit', :magenta)
say_status('info', '=================================', :magenta)
# TODO: v9.0.0.beta1 of the plugin assumes you are using either yarn or importmap;
# it does not support Sprockets for JS. It also provides no easy way to skip
# running its assets generator (yet). For now, we will use a local version of
# lib/generators/blacklight_range_limit/assets_generator.rb that does nothing.
# it does not support Sprockets for JS. So we'll --skip-assets here.

# If we want TRLN Argon to use the plugin this way by default (with no JS), we can.
# If we want the chart.js histogram supported by TRLN Argon we will need to
Expand All @@ -29,7 +27,7 @@ def run_dependency_generators
# See:
# https://github.com/projectblacklight/blacklight_range_limit/blob/main/lib/generators/blacklight_range_limit/install_generator.rb
# https://github.com/projectblacklight/blacklight_range_limit/blob/main/lib/generators/blacklight_range_limit/assets_generator.rb
generate 'blacklight_range_limit:install'
generate 'blacklight_range_limit:install --skip-assets'
end

# this should match whatever's in trln_argon.gemspec
Expand Down
2 changes: 1 addition & 1 deletion trln_argon.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |s|
s.add_dependency 'blacklight', '~> 8.7'
s.add_dependency 'blacklight_advanced_search', '~> 8.0.0.alpha2'
s.add_dependency 'blacklight-hierarchy', '~> 6.3'
s.add_dependency 'blacklight_range_limit', '9.0.0.beta1'
s.add_dependency 'blacklight_range_limit', '9.0.0.beta2'
s.add_dependency 'git', '>= 1.11.0', "< 2"
s.add_dependency 'rails_autolink', '~> 1.1'
s.add_dependency 'library_stdnums', '~> 1.6'
Expand Down

0 comments on commit ea5c143

Please sign in to comment.