Refactor, rebase and add tests

trln · Dec 12, 2023 · 87c36ab · 87c36ab
1 parent 4364992
commit 87c36ab
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/trln_argon/solr_document/highwire_field_mapping.rb b/lib/trln_argon/solr_document/highwire_field_mapping.rb
@@ -1,8 +1,7 @@
-# frozen_string_literal: true
-
 module TrlnArgon
   module SolrDocument
     module HighwireFieldMapping
+      # https://raw.githubusercontent.com/zotero/translators/db2771d52d89d1480ff98efbd6968565893f2184/Embedded%20Metadata.js
       MAPPING = {
         'title_main' => 'citation_title',
         'publication_year_sort' => 'citation_publication_date',
@@ -26,11 +25,11 @@ def highwire_metadata_tags
 
       private
 
-      def process_docvalue(result, metadata_key, docvalue)
+      def process_docvalue(result, key, docvalue)
         if docvalue.is_a?(Array)
-          docvalue.each { |dv| result << [metadata_key, dv] }
+          docvalue.each { |dv| result << [key, dv] }
         else
-          result << [metadata_key, docvalue]
+          result << [key, docvalue]
         end
       end