Switch default for foreach_point_neighbor #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les.jlOpen into change_defaults_of_nhs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 68.77% 68.73% -0.04%
==========================================
Files 93 93
Lines 5780 5780
==========================================
- Hits 3975 3973 -2
- Misses 1805 1807 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
requested changes
Dec 23, 2024
…les.jlOpen into change_defaults_of_nhs
efaulhaber
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM! @LasNikas you should probably have a closer look to make sure this doesn't cause any problems with buffers and active/inactive particles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using each_moving_particle as default leads to hard to debug issues especially in multi system simulations.