Setting shutdown asyncio event in a thread-safe manner #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we need to be careful, when using asyncio with multi-threading. The non-graceful shutdown was happening due to "RuntimeError: Non-thread-safe operation invoked on an event loop other than the current one\n\nA" (I started
asyncio.run
withdebug=True
). Thus I'm replacing asyncio with threading.Tests: https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/jobs/129814805
tests ran for branch
oandreeva_metrics_refactor
, but the change is the same. I suggest to merge this commit to the current perf PR and merge perf PR to main, i.e. not wait for metrics follow up.