-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add log probabilities and number of input tokens to additional outputs #75
Conversation
2459e0a
to
17ae25c
Compare
For example: input parameter text_output: [{
'5': {'logprob': -1.0246853828430176, 'rank': 1, 'decoded_token': ' the'},
'10': {'logprob': -2.2121853828430176, 'rank': 2, 'decoded_token': ' a'}
}] text_output: [{
'1385': {'logprob': -3.2646501064300537, 'rank': 1, 'decoded_token': ' term'},
'78': {'logprob': -3.7529313564300537, 'rank': 2, 'decoded_token': ' first'}
}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc comments - LGTM otherwise
Co-authored-by: Ryan McCormick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oandreeva-nv for second opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does the PR do?
Add log probabilities and number of input tokens to additional outputs.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
N/A
Where should the reviewer start?
Start with the documentation, and then move to the implementation and finally the tests.
Test plan:
New tests for the new additional outputs will be added.
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A