Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report histogram metrics to Triton metrics server #58

Merged
merged 36 commits into from
Aug 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0686a7c
Add first supported metrics
yinggeh Jul 29, 2024
21e2356
Update comments
yinggeh Jul 30, 2024
d95bb2c
Minor update
yinggeh Aug 1, 2024
321faa0
Add metrics test
yinggeh Aug 3, 2024
468539f
Fix copyright
yinggeh Aug 5, 2024
8eba2f0
Remove unused metrics and update comments
yinggeh Aug 6, 2024
6f97f6f
Minor update
yinggeh Aug 6, 2024
bf7669e
Minor updates
yinggeh Aug 6, 2024
e9d0dbb
Minor fix
yinggeh Aug 7, 2024
7d0dc5b
Remove unused module
yinggeh Aug 7, 2024
979dc02
Fix "metrics not supported error" when building with TRITON_ENABLE_ME…
yinggeh Aug 8, 2024
3dd04c5
Fix "metrics not supported error" when building with TRITON_ENABLE_ME…
yinggeh Aug 8, 2024
07f2575
Simply test
yinggeh Aug 8, 2024
2135145
Completely turn off metrics
yinggeh Aug 9, 2024
56aea05
Add vLLM disable_log_stats config test
yinggeh Aug 9, 2024
0dadc8e
Test metrics are enabled by default if disable_log_stats is not set.
yinggeh Aug 9, 2024
8d8fd2a
Update tests based on comments
yinggeh Aug 9, 2024
4f2e217
Remove _log_gauge
yinggeh Aug 9, 2024
d22fd03
Resolve comments
yinggeh Aug 9, 2024
c8bdb6e
Merge branch 'main' of github.com:triton-inference-server/vllm_backen…
yinggeh Aug 9, 2024
8280d26
Update
yinggeh Aug 9, 2024
6fa7ae3
Change temp directory
yinggeh Aug 9, 2024
89ca6f4
Disable metrics report by default. Controlled by parameter "REPORT_ME…
yinggeh Aug 15, 2024
1158fee
Test server option set --allow-metrics=false
yinggeh Aug 15, 2024
a99d38b
Add docs
yinggeh Aug 15, 2024
de8f25b
Minor update
yinggeh Aug 15, 2024
b1333ce
Both args checking
yinggeh Aug 15, 2024
de7ff8f
Add histogram test
yinggeh Aug 12, 2024
9534298
Longer time for A100
yinggeh Aug 14, 2024
38ac8d6
Update comment
yinggeh Aug 15, 2024
ebdf14e
Add histogram metrics to doc
yinggeh Aug 15, 2024
0d67322
Update docs
yinggeh Aug 16, 2024
10d8a69
Make metrics test more robust
yinggeh Aug 16, 2024
b7f4002
Merge branch 'main' into yinggeh-DLIS-7113-support-histogram-metric-type
yinggeh Aug 16, 2024
bba181e
Remove empty newline
yinggeh Aug 16, 2024
2d7488d
Change assertTrue(a>b) to assertGreater(a, b)
yinggeh Aug 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update
yinggeh committed Aug 9, 2024
commit 8280d261346ca947ec11e97418da66f1ec2e80a6
11 changes: 6 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -110,11 +110,12 @@ In this case, please install vLLM first. You can do so by running
container with the following commands:

```
vllm_tmp_dir=/tmp/backends/vllm_backend
mkdir -p /opt/tritonserver/backends/vllm $vllm_tmp_dir
git clone https://github.com/triton-inference-server/vllm_backend.git $vllm_tmp_dir
cp -r $vllm_tmp_dir/src/* /opt/tritonserver/backends/vllm
rm -rf $vllm_tmp_dir
TEMP_TRITON_VLLM_DIR=/tmp/backends/vllm_backend
mkdir -p /opt/tritonserver/backends/vllm $TEMP_TRITON_VLLM_DIR
git clone https://github.com/triton-inference-server/vllm_backend.git $TEMP_TRITON_VLLM_DIR
cp -r $TEMP_TRITON_VLLM_DIR/src/* /opt/tritonserver/backends/vllm
rm -rf $TEMP_TRITON_VLLM_DIR
rm -d /tmp/backends
```

## Using the vLLM Backend
2 changes: 1 addition & 1 deletion src/utils/metrics.py
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ def _log_counter(self, counter, data: Union[int, float]) -> None:
counter.increment(data)

def log(self, stats: VllmStats) -> None:
"""Logs tracked stats to triton metrics server every iteration.
"""Logs to triton metrics server every iteration.

Args:
stats: Created by LLMEngine for use by VllmStatLogger.