Updating vLLM tests to handle changes between vLLM version 0.2.3 and 0.3.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbkyang-nvi
reviewed
Feb 2, 2024
jbkyang-nvi
previously approved these changes
Feb 2, 2024
oandreeva-nv
changed the title
pskiran1
approved these changes
Feb 7, 2024
| with open("vllm_engine_output.pkl", "wb") as f: | ||
| pickle.dump(python_vllm_output, f) | ||
|
|
||
| return |
There was a problem hiding this comment.
Perhaps the return statement can be removed here since it always returns None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated accuracy test not to run 2 vLLM engines at the same time, due to vllm-project/vllm#2248