docs: hello world readme #32
Conversation
…ence-server/triton-distributed into nnshah1-hello-world
…ence-server/triton-distributed into nnshah1-hello-world
examples/hello_world/README.md
Outdated
| #### Standalone Operator | ||
|
|
||
| The encoder-decoder operator is a standalone python class that | ||
| implements the Operator interface. Internally it makes remote requests | ||
| to other workers. Generally a standalone operator can make use of | ||
| other operators for its work but isn't required to. |
There was a problem hiding this comment.
Should "Standalone" be more like "Custom"? Custom operator that you can implement to do what you want? In this case, it just happened to be encoder-decoder, but it could be anything and has to be implemented by the user.
Compared to TritonCoreOperator which is a built-in/pre-defined operator that can be imported from the library out of the box.
There was a problem hiding this comment.
not sure - any other thoughts ... custom operator seemed a lot like custom model .... and I think its a usual case. custom some how implies and outlier to me - like you only need it sometimes .... maybe its just Operator? or Generic Operator?
There was a problem hiding this comment.
We generally have used the term "custom" to describe the scenario where we've defined an interface for you that you can implement/use to do your own things, ex:
- custom backend
- custom metrics
- custom tracing
- etc
There was a problem hiding this comment.
But don't mind whatever you go with for now - can be tuned
There was a problem hiding this comment.
I would prefer custom operator as well.
Co-authored-by: Tanmay Verma <[email protected]>
Co-authored-by: Tanmay Verma <[email protected]>
Co-authored-by: Tanmay Verma <[email protected]>
Co-authored-by: Ryan McCormick <[email protected]>
…n-inference-server/triton-distributed into nnshah1-hello-world-readme
|
merged seperately |
What does the PR do?
MVP documentation for running hello world example.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)