-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add fix and test for 'triton' with no args #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a general workflow question:
Do we want to error out for someone using the triton
command without any args? What are the cons of something like this?
/opt/tritonserver# triton
usage: triton [-h] [-v]
{import,remove,list,start,infer,profile,metrics,config,status} ...
triton: For further information, ex: triton import -h
/opt/tritonserver# echo $?
0
Can you clarify the question? Are you asking if we care whether the return code is |
Yup, I was primarily wondering if we want to consider the no args command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! With this the error message should be much more helpful than the previous unrelated profile error.
Before:
After: