fix: Use profile subcommand for GenAI-Perf starting in 24.08 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the preemptive PR, David! This will probably stick around for a while until we're ready for 24.08 updates. Also just FYI, there's a known issue where the |
|
Relevant genai-perf PR change: triton-inference-server/client#745 |
rmccorm4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once GenAI-Perf 24.08 is released, its profiling capability will be moved to
genai-perf profile <args>instead ofgenai-perf <args>. Opening a PR so that once that version of GenAI-Perf is used in Triton CLI, the associated update is made to the subprocess call in Triton CLI.Also removed the TRT-LLM backend naming hotfix for versions before 24.05.