refactor: Simplify testing with ScopedTritonServer instead of pytest fixtures #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
tests/utils.py
Outdated
| self.timeout = timeout | ||
|
|
||
| def __enter__(self): | ||
| run(["remove", "-m", "all"]) |
There was a problem hiding this comment.
Can you make the following tweaks for use of clear()?
- move the
_clear()helper intoutils.pyand use it here? - Add a
if repo:clause to the_clear()helper, I just realized it's missing. Will look like this. - Update the other calls to do
utils.clear()instead ofself._clear()
There was a problem hiding this comment.
Would it make sense to move all the helper functions into utils.py? It will reduce the replication of helper functions between test_cli.py and test_e2e.py.
There was a problem hiding this comment.
Sounds good if being replicated
rmccorm4
reviewed
May 31, 2024
There was a problem hiding this comment.
Nice changes! Left some minor comments. CC @krishung5 for comments too.
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
rmccorm4
reviewed
May 31, 2024
krishung5
reviewed
May 31, 2024
krishung5
reviewed
May 31, 2024
rmccorm4
changed the title
rmccorm4
changed the title
rmccorm4
changed the title
krishung5
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been raised to address Jira Ticket [DLIS-6803]
Replaces the existing (pytest.fixture and generator) approach with
ScopedTritonServer, a context manager, that starts and kills the server.Specific features being added/addressed in this PR:
ScopedTritonServer) abstracts away process id logic from the test functionsScopedTritonServerFunctions:__enter__(): Sends start up command and polls until server is ready__exit__(): Kills the server