Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Avoid failing tests on unknown kill_server behavior #102

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

rmccorm4
Copy link
Collaborator

@rmccorm4 rmccorm4 commented Jan 23, 2025

CLI tests in CI intermittently fail with AttributeError: ScopedTritonServer has no attribute self.proc. I haven't dug deeper to see why this is happening yet - but this adds an initialization and some error handling to try to avoid failing tests on this behavior.

    def kill_server(self, timeout: int = 60):
        try:
>           self.proc.terminate()
E           AttributeError: 'ScopedTritonServer' object has no attribute 'proc'
tests/utils.py:151: AttributeError

@rmccorm4 rmccorm4 merged commit 6d5ca07 into main Jan 23, 2025
6 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick/cli/graceful_exit branch January 23, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants