Upadate default branch post 25.01 #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession (#109) Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to 0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum repositories, thus we must use pip to install the version we want. See mayeut/patchelf-pypi#87
nv-tusharma
approved these changes
Feb 1, 2025
| @@ -187,7 +187,8 @@ explicitly provided, the default value for this option is 4. | |||
| Use a recent cmake to build. First install the required dependencies. | |||
|
|
|||
| ``` | |||
| $ apt-get install patchelf rapidjson-dev | |||
| $ apt-get install rapidjson-dev python3-pip | |||
There was a problem hiding this comment.
Why can't we pin the installation with apt itself? So L190 would look like:
apt-get install patchelf==0.17.2 rapidjson-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87