Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for sending response after sending complete final flag #7504

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Aug 6, 2024

What does the PR do?

Enhance existing test on response sender when the model would sent additional response(s) after sending the complete final flag. The additional response(s) should cause an exception to be raised.

This test enhancement is due to deleting the response factory after the response sender has sent the complete final flag, to ensure the model cannot accidentally trigger a dereference on the deleted response factory by sending response(s) after sending complete final flag.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/python_backend#373
triton-inference-server/vllm_backend#55

Where should the reviewer start?

Start with the related PRs before coming back to this one.

Test plan:

N/A

  • CI Pipeline ID: 17156719

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui force-pushed the jacky-res-factory-del branch from 6ff71a1 to 8723c75 Compare August 6, 2024 23:12
@kthui kthui marked this pull request as ready for review August 6, 2024 23:17
@kthui kthui merged commit 6636fc9 into main Aug 7, 2024
3 checks passed
@kthui kthui deleted the jacky-res-factory-del branch August 7, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: test Adding missing tests or correcting existing test
Development

Successfully merging this pull request may close these issues.

2 participants