Remove boost::filesystem from builds #6810
Conversation
rmccorm4
changed the title
| @@ -974,7 +974,6 @@ def create_dockerfile_buildbase(ddir, dockerfile_name, argmap): | |||
| RUN wget -O /tmp/boost.tar.gz \ | |||
| https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && \ | |||
| (cd /tmp && tar xzf boost.tar.gz) && \ | |||
| cd /tmp/boost_1_80_0 && ./bootstrap.sh --prefix=/usr && ./b2 install && \ | |||
There was a problem hiding this comment.
May I ask you to briefly clarify where else boost is used and why we are keeping it here?
There was a problem hiding this comment.
We use the header-only boost libs (span in cache, interprocess_lock in python backend, stacktrace in server, and some others) in several places.
boost::filesystem was the only one that needed a runtime shared library requiring this extra bootstrap+install step.
There was a problem hiding this comment.
Is there still an external dependency on libboost? Or could these header-only libs be included in-tree? Also, what is now the minimal version of the needed boost? Does it work again with ubuntu-22.04-shipped boost 1.74?
… rmccormick-filesystem
|
Passed L0_model_config and the relevant |
|
boost is now not required, right? starting from what triton release? thanks! |
Server: #6810
Core: triton-inference-server/core#319
Fixes: #6745