Disable cudnn option #123
Merged
Disable cudnn option #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tabrizian are you okay to take a look at this? Thanks |
Tabrizian
reviewed
Jan 13, 2024
Done! |
|
@Tabrizian is this being looked at? |
|
@kthui do you know who can review this change? |
|
@HennerM I'm so sorry I was out of the office when I was mentioned and might have missed the notification for this PR. This looks good to me. Thanks for your contribution. We need to run this PR through CI and add some testing before merging it. We'll merge the PR if the CI looks green. |
Tabrizian
approved these changes
May 9, 2024
|
@Tabrizian Thanks for approving. Can you help with merging as well? |
tanmayv25
approved these changes
May 28, 2024
kthui
approved these changes
May 28, 2024
tanmayv25
reviewed
May 28, 2024
Should be able to merge it soon. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've occasionally had issues when multiple models that use cuDNN, (we sometimes see
CUDNN_INTERNAL_ERRORand sometimes GPU memory will spike when running a kernel from cuDNN) so have found it beneficial to disable it in our own fork of the repo. It would be helpful to have an option to do this upstreamed.If it would be helpful I could try and find a repro of the
CUDNN_INTERNAL_ERRORissue but that may take a bit more time.