Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix requested output deleting extra outputs #390

Merged
merged 2 commits into from
Dec 11, 2024
+11 −3
Merged

fix: Fix requested output deleting extra outputs #390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2082a3c
fix: Hold GIL when deleting numpy array
kthui Dec 10, 2024
d053a3d
chore: setting py obj to None may not destruct the object
kthui Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pb_stub.cc
View file
Original file line number Diff line number Diff line change
@@ -1032,9 +1032,9 @@ Stub::~Stub()

{
py::gil_scoped_acquire acquire;
async_event_loop_ = py::none();
background_futures_ = py::none();
model_instance_ = py::none();
py::object async_event_loop_local(std::move(async_event_loop_));
py::object background_futures_local(std::move(background_futures_));
py::object model_instance_local(std::move(model_instance_));
}
stub_instance_.reset();
stub_message_queue_.reset();
8 changes: 8 additions & 0 deletions src/pb_tensor.cc
View file
Original file line number Diff line number Diff line change
@@ -503,6 +503,14 @@ PbTensor::~PbTensor() noexcept(false)
{
pb_memory_.reset();
DeleteDLPack();

#ifdef TRITON_PB_STUB
{
py::gil_scoped_acquire acquire;
py::array numpy_array_local(std::move(numpy_array_));
py::array numpy_array_serialized_local(std::move(numpy_array_serialized_));
}
#endif
}

const std::string&