Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken selection of RAPIDS-Triton version #415

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix broken selection of RAPIDS-Triton version #415

merged 1 commit into from
Nov 22, 2024

Conversation

wphicks
Copy link
Collaborator

@wphicks wphicks commented Nov 22, 2024

Fix build bug introduced by #404 / #409 which prevents RAPIDS Triton version from being passed properly through build pipeline.

dantegd
dantegd approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wphicks
Copy link
Collaborator Author

wphicks commented Nov 22, 2024

Admin merging because this will require another fix to pass CI.

@wphicks wphicks merged commit f455352 into main Nov 22, 2024
1 check passed
wphicks added a commit that referenced this pull request Nov 22, 2024
@wphicks
Backport fixes for 24.11 dependencies (#418)
9f0bb85 
* Update to RAPIDS-Triton 24.10 (#414)

* Fix broken selection of RAPIDS-Triton version (#415)

* Remove deprecated numpy.product usage (#416)

Admin-merging because this will not pass CI without an upstream change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wphicks @dantegd