Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP live connections on server shutdown #335

Merged
merged 7 commits into from
Apr 9, 2024
Merged

HTTP live connections on server shutdown #335

merged 7 commits into from
Apr 9, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Mar 15, 2024 •
edited
Loading

Related PR: triton-inference-server/server#6986

Add a new C-API to update the server exit timeout value and then stop the server.

@kthui kthui mentioned this pull request Mar 15, 2024
Merged
@kthui kthui changed the title HTTP server connection timeout poll HTTP live connections on server shutdown Mar 15, 2024
@kthui kthui marked this pull request as ready for review March 15, 2024 23:52
@kthui kthui requested a review from nnshah1 March 18, 2024 22:56
nnshah1
nnshah1 previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight tweak to description of API - to indicate that it overrides the original value if set.

@kthui kthui requested review from nnshah1 and rmccorm4 March 20, 2024 18:50
nnshah1
nnshah1 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kthui kthui merged commit 56d60cc into main Apr 9, 2024
1 check passed
@kthui kthui deleted the jacky-http-shutdown branch April 9, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnshah1 nnshah1 nnshah1 approved these changes

@whoisj whoisj Awaiting requested review from whoisj

@jbkyang-nvi jbkyang-nvi Awaiting requested review from jbkyang-nvi

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kthui @nnshah1 @rmccorm4