Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic for ignoring duplicate unload requests #309

Merged
merged 3 commits into from
May 8, 2024

Conversation

nnshah1
Copy link
Contributor

@nnshah1 nnshah1 commented Jan 5, 2024

Based on this issue triton-inference-server/server#6359, and the debugging by: iyLester - a quick change to the logic to identify a duplicate unload request.

Previously the logic would identify every request as 'not first unload', change to identify duplicate unload.

kthui
kthui previously approved these changes Jan 5, 2024
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!
so the new logic is

action:     unload -> load -> unload -> unload
duplicate:    no       no       no       yes

@Joffref
Copy link

Joffref commented May 4, 2024

Any chance it get merged soon? 👍

@nnshah1
Copy link
Contributor Author

nnshah1 commented May 4, 2024

Any chance it get merged soon? 👍

The main thing we are waiting on is to add a test case - will see if we can prioritize for 24.06 release.

Let us know if that causes issues for you

@Joffref
Copy link

Joffref commented May 4, 2024

Any chance it get merged soon? 👍

The main thing we are waiting on is to add a test case - will see if we can prioritize for 24.06 release.

Let us know if that causes issues for you

As of today, knowing Dragonfly is about to release its repository agent, this an ongoing issue that can block us from using it. Is there any workaround that we can use until the release of this patch?

@nnshah1
Copy link
Contributor Author

nnshah1 commented May 4, 2024

Any chance it get merged soon? 👍

The main thing we are waiting on is to add a test case - will see if we can prioritize for 24.06 release.
Let us know if that causes issues for you

As of today, knowing Dragonfly is about to release its repository agent, this an ongoing issue that can block us from using it. Is there any workaround that we can use until the release of this patch?

I'll bring this up with the team - and see if we can expedite - dragonfly looks really interesting!

@nnshah1 nnshah1 merged commit 469cbb8 into main May 8, 2024
1 check passed
@nnshah1 nnshah1 deleted the nnshah1-agent-lifecycle-fix branch May 29, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants