-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SSL consideration in S3 migration guide #24772
base: master
Are you sure you want to change the base?
Conversation
@@ -346,7 +346,6 @@ implementation is recommended. Legacy support will be deprecated and removed. | |||
The following considerations apply to legacy configurations moving to the native | |||
implementation: | |||
|
|||
* SSL is always enabled and cannot be disabled. | |||
* Client-side encryption is not supported. Server-side encryption (SSE) is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this one too. Is the client-side referring to Trino doing encryption or else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe things got mixed up in writing this .. spooling protocol vs native file system ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it seems so. SSL is required for S3 spooling as it generates presigned URIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still worth mentioning: "Multipart (non-streaming) writes and upload are not supported."? Does it really add value or should the entire "considerations" section be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what that means in the context eithere.. lets wait for @jhlodin to chime in about where that info came from, but I think we can remove it all.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: