Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][UMA-1115] WC bug: retry on failed notification to dApp #2367

Conversation

dianasavvatina
Copy link
Contributor

Proposed changes

UMA-1115

If the tx confirmation to the WC server failed (e.g. the dApp has disconnected), wallet allows to click Confirm over and over again performing the same operation!

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Added exception in packages/state/src/hooks/useAsyncActionHandler.ts:

          await walletKit.respondSessionRequest({ topic: requestId.topic, response });
          throw new CustomError("dApp was not notified test message");

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now
image image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:28am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:28am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:28am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:28am

@dianasavvatina dianasavvatina self-assigned this Feb 4, 2025
@dianasavvatina dianasavvatina changed the title [Umami web][UMA-1115] fix: WC bug: retry on failed notification to dApp [web][UMA-1115] fix: WC bug: retry on failed notification to dApp Feb 4, 2025
@dianasavvatina dianasavvatina changed the title [web][UMA-1115] fix: WC bug: retry on failed notification to dApp [web][UMA-1115] WC bug: retry on failed notification to dApp Feb 4, 2025
@dianasavvatina dianasavvatina changed the title [web][UMA-1115] WC bug: retry on failed notification to dApp [Web][UMA-1115] WC bug: retry on failed notification to dApp Feb 4, 2025
@dianasavvatina dianasavvatina force-pushed the UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp branch from 1ac4d7e to cf27736 Compare February 4, 2025 15:38
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

@dianasavvatina dianasavvatina enabled auto-merge (rebase) February 5, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants