-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web][UMA-1115] WC bug: retry on failed notification to dApp #2367
Merged
dianasavvatina
merged 1 commit into
main
from
UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp
Feb 5, 2025
Merged
[Web][UMA-1115] WC bug: retry on failed notification to dApp #2367
dianasavvatina
merged 1 commit into
main
from
UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
changed the title
[Umami web][UMA-1115] fix: WC bug: retry on failed notification to dApp
[web][UMA-1115] fix: WC bug: retry on failed notification to dApp
Feb 4, 2025
dianasavvatina
changed the title
[web][UMA-1115] fix: WC bug: retry on failed notification to dApp
[web][UMA-1115] WC bug: retry on failed notification to dApp
Feb 4, 2025
dianasavvatina
changed the title
[web][UMA-1115] WC bug: retry on failed notification to dApp
[Web][UMA-1115] WC bug: retry on failed notification to dApp
Feb 4, 2025
dianasavvatina
force-pushed
the
UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp
branch
from
February 4, 2025 15:38
1ac4d7e
to
cf27736
Compare
OKendigelyan
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small comment
dianasavvatina
force-pushed
the
UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp
branch
from
February 5, 2025 10:24
cf27736
to
1ad0d70
Compare
dianasavvatina
deleted the
UMA-1115/fix-bug-wc-retry-on-failed-notification-to-dapp
branch
February 5, 2025 10:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
UMA-1115
If the tx confirmation to the WC server failed (e.g. the dApp has disconnected), wallet allows to click Confirm over and over again performing the same operation!
Types of changes
Steps to reproduce
Added exception in packages/state/src/hooks/useAsyncActionHandler.ts:
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist