Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: hints for send tez, Originate, Contract Call
Browse files Browse the repository at this point in the history
dianasavvatina committed Jan 27, 2025
1 parent 61181d3 commit a89a58e
Showing 3 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@ describe("<OriginationOperationSignPage />", () => {

expect(screen.getByTestId("sign-page-header")).toHaveTextContent("Origination Request");
expect(screen.getByTestId("app-name")).toHaveTextContent("mockDappName");
expect(screen.queryByTestId("hints-accordion")).not.toBeInTheDocument();
expect(screen.getByTestId("hints-accordion")).toBeInTheDocument();
});

it("passes correct payload to sign handler", async () => {
Original file line number Diff line number Diff line change
@@ -407,7 +407,7 @@ describe("<useHandleBeaconMessage />", () => {
);
expect(screen.getByTestId("sign-page-header")).toHaveTextContent("Send Request");
expect(screen.getByTestId("app-name")).toHaveTextContent("mockDappName");
expect(screen.queryByTestId("hints-accordion")).not.toBeInTheDocument();
expect(screen.getByTestId("hints-accordion")).toBeInTheDocument();

expect(mockToast).not.toHaveBeenCalled();
});
6 changes: 4 additions & 2 deletions packages/core/src/Hints.ts
Original file line number Diff line number Diff line change
@@ -4,8 +4,10 @@ type HintData = {
header?: string;
description?: string;
};
const basicOperationHeader = undefined;
const basicOperationDescription = undefined;
const basicOperationHeader =
"A confirmation takes 1 block (8 seconds). The transaction becomes final and irreversible after 2 blocks (16 seconds).";
const basicOperationDescription =
"A confirmation means that the block is confirmed by the network but the operation can still be cancelled due to chain reorganizations. Finality means that the operation is irreversible.";

export const Hints: Record<SignPage, HintData> = {
TezSignPage: {

1 comment on commit a89a58e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title Lines Statements Branches Functions
apps/desktop Coverage: 83%
83.82% (1788/2133) 79.58% (850/1068) 78.27% (454/580)
apps/web Coverage: 83%
83.82% (1788/2133) 79.58% (850/1068) 78.27% (454/580)
packages/components Coverage: 97%
97.51% (196/201) 95.91% (94/98) 88.13% (52/59)
packages/core Coverage: 82%
82.64% (219/265) 72.51% (95/131) 81.66% (49/60)
packages/crypto Coverage: 100%
100% (43/43) 90.9% (10/11) 100% (7/7)
packages/data-polling Coverage: 96%
94.63% (141/149) 87.5% (21/24) 92.85% (39/42)
packages/multisig Coverage: 98%
98.47% (129/131) 85.71% (18/21) 100% (36/36)
packages/social-auth Coverage: 100%
100% (21/21) 100% (11/11) 100% (3/3)
packages/state Coverage: 85%
84.3% (827/981) 80.5% (190/236) 77.83% (302/388)
packages/tezos Coverage: 89%
88.72% (118/133) 94.59% (35/37) 86.84% (33/38)
packages/tzkt Coverage: 89%
87.32% (62/71) 87.5% (14/16) 80.48% (33/41)

Please sign in to comment.