-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DAL file server tutorial for Ghostnet #424
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look ok to me.
I haven't been able to finish the tutorial, as expected:
latest
doesn't yet work with the current bootstrap node on Ghostnet- slots are not attested because there are not enough DAL-enabled bakers on Ghostnet.
But I guess this PR is a preparation for the case when these two issues will be fixed.
docs/tutorials/build-files-archive-with-dal/publishing-on-the-dal.md
Outdated
Show resolved
Hide resolved
c55f7f3
to
9e1fba1
Compare
9e1fba1
to
259a81c
Compare
76978e9
to
5768450
Compare
I followed this tutorial on 27 January and it seems to work on Ghostnet. Can anyone else review? I think this update may finally be ready to go. @ezal @francoisthire |
``` | ||
|
||
This script assumes that your local node is running at http://127.0.0.1:8732. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the octez-client
command above also requires this assumption. I suggest you move it before the first command that requires it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this:
The Octez client assumes that your local node is running at http://127.0.0.1:8732. If your node is running at a different host name or port, pass the host name and port of the node to the
--endpoint
argument. For example, if the node is running on port 8733, include--endpoint http://127.0.0.1:8733
in the command.
of type unit with kernel "$(cat installer.hex)" --burn-cap 2.0 --force | ||
|
||
octez-smart-rollup-node --endpoint ${ENDPOINT} \ | ||
octez-smart-rollup-node --endpoint http://127.0.0.1:8732 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't understand why sometime the endpoint is specified sometimes it is not. My guess would be than when it is not needed as for octez-client
, you don't specify it, but for the octez-smart-rollup-node
there might be no default so it needs to be specified?
Why not putting the endpoint everywhere so that a reader can copy/paste it easily and modify it if it uses a different endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's klunky and unnecessary to put the endpoint in every command. I'll remove the rest of them unless you really think people should specify --endpoint every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it.
42a0c4a
to
d991104
Compare
Update the DAL file server tutorial:
--observer-profiles
to be in observer mode for the DAL node--legacy
more for the DAL trusted setupPreview: https://docs-staging-git-update-dal-file-tutorial-trili-tech.vercel.app/tutorials/build-files-archive-with-dal
As noted in the comments, this tutorial doesn't currently work on Ghostnet because of an issue with DAL attesters. However, we may want to merge this update now anyway because it no longer works consistently on Weeklynet.
There is a note that says:
Should this be 8 blocks for Ghostnet because that's the attestation_delay?