fix(suite-native): import and show Taproot descriptors correctly

[yanascz]

Resolves #16744

[coderabbitai]

Walkthrough

The changes add the workspace dependency @trezor/utils to both the accounts import and accounts management modules. The PR introduces Taproot descriptor conversion logic by importing and using the convertTaprootXpub function from @trezor/utils. In the accounts import module, the function is applied when calling TrezorConnect.getAccountInfo, replacing the original descriptor with a converted value if available. In the accounts management module, the converted descriptor is used to generate the QR code data by modifying the value passed to the XpubQRCodeBottomSheet component. Comments are included to clarify that the conversion is required for Taproot descriptors.

Assessment against linked issues

Objective	Addressed	Explanation
Enable BTC Taproot account addition by converting Taproot descriptors (#16744)	✅

Possibly related PRs

• Build: connect plugins support esm #16729: The changes in the main PR are related to the introduction of the convertTaprootXpub function from the @trezor/utils package, which is also referenced in the retrieved PR, indicating a shared dependency and functionality enhancement.
• Fix/use exports with import and require #16765: The changes in the main PR, which involve adding a dependency on @trezor/utils and utilizing its convertTaprootXpub function, are related to the retrieved PR that also modifies the @trezor/utils package, specifically by introducing an exports field, indicating a connection through the shared package.

Suggested labels

no-project

Suggested reviewers

• martykan
• mroz22

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9561654 and 2d35566.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (6)

• suite-native/module-accounts-import/package.json (1 hunks)
• suite-native/module-accounts-import/src/accountsImportThunks.ts (3 hunks)
• suite-native/module-accounts-import/tsconfig.json (1 hunks)
• suite-native/module-accounts-management/package.json (1 hunks)
• suite-native/module-accounts-management/src/components/AccountSettingsShowXpubButton.tsx (3 hunks)
• suite-native/module-accounts-management/tsconfig.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• suite-native/module-accounts-import/package.json
• suite-native/module-accounts-management/package.json
• suite-native/module-accounts-import/src/accountsImportThunks.ts
• suite-native/module-accounts-management/src/components/AccountSettingsShowXpubButton.tsx

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: build-deploy
• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: build-web
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: build-deploy
• GitHub Check: prepare_android_test_app
• GitHub Check: EAS Update
• GitHub Check: transport-e2e-test
• GitHub Check: build
• GitHub Check: test
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (2)

suite-native/module-accounts-management/tsconfig.json (1)

37-38: Inclusion of New Utility and Styles References

The addition of the references:

• { "path": "../../packages/styles" } (line 37)
• { "path": "../../packages/utils" } (line 38)

is aligned with the PR objectives. Including "../../packages/utils" enables access to utility functions needed for the Taproot descriptor conversion logic, while the styles reference remains consistent with related dependencies.

suite-native/module-accounts-import/tsconfig.json (1)

46-46: Addition of Utils Package Reference

The newly added reference { "path": "../../packages/utils" } (line 46) is an essential update that ensures the module can use utility functions (in particular, the convertTaprootXpub function) from the workspace dependency @trezor/utils as required for the Taproot descriptor handling improvements.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

🚀 Expo preview is ready!

• Project → trezor-suite-preview
• Platforms → android, ios
• Scheme → trezorsuitelite
• Runtime Version → 24
• More info

Learn more about 𝝠 Expo Github Action

[matejkriz]

It works as expected 👍