-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(suite): autofix for sort-imports eslint rule #16676
Conversation
82dd0be
to
bc49078
Compare
gfo && gco -b test-repro-sort-import-suite origin/chore/sort-imports-suite
git reset HEAD~1 --hard
git cherry-pick 347a3f91c21ce7917ed7e4115f2e991b3500f478
cd packages/suite
yarn g:eslint --fix # 74 errors
yarn g:eslint --fix # 25 errors
yarn g:eslint --fix # 11 errors
yarn g:eslint --fix
yarn g:eslint --fix
# finally no more errors
ga .
git reset src/components/suite/index.tsx src/hooks/wallet/__tests__/useRbfForm.test.tsx src/middlewares/suite/index.ts src/middlewares/wallet/index.ts src/reducers/store.ts
gc -m"stuff" -n
git stash
git revert 347a3f91c21ce7917ed7e4115f2e991b3500f478
git diff HEAD origin/chore/sort-imports-suite | cat
# produced EMPTY diff |
bc49078
to
3fa1617
Compare
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 143 files out of 300 files are above the max files limit of 150. You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Partial fix for #14190.
The following was done:
packages/suite
.yarn g:eslint --fix
run repeatedly until fixed number of warnings was reported.packages/suite/src/components/suite/index.tsx
packages/suite/src/hooks/wallet/__tests__/useRbfForm.test.tsx
packages/suite/src/middlewares/suite/index.ts
packages/suite/src/middlewares/wallet/index.ts
packages/suite/src/reducers/store.ts