feat(suite): allow lower gas prices for eth networks #16066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adderpositive
added
feature
adderpositive
force-pushed
the
feat/allow-lower-gas-price
branch
from
ae47073 to
4a4c13a
Compare
|
🚀 Expo preview is ready!
|
tomasklim
reviewed
Dec 20, 2024
adderpositive
force-pushed
the
feat/network-display-symbol
branch
4 times, most recently
from
eef8bc2 to
9e3527a
Compare
adderpositive
force-pushed
the
feat/allow-lower-gas-price
branch
from
4a4c13a to
9e3527a
Compare
adderpositive
force-pushed
the
feat/allow-lower-gas-price
branch
2 times, most recently
from
74cfd2b to
c22ce2f
Compare
tomasklim
reviewed
Dec 25, 2024
tomasklim
reviewed
Dec 25, 2024
tomasklim
force-pushed
the
feat/allow-lower-gas-price
branch
3 times, most recently
from
489029b to
9725b52
Compare
tomasklim
force-pushed
the
feat/allow-lower-gas-price
branch
from
9725b52 to
7e08d1e
Compare
mroz22
reviewed
Jan 1, 2025
| @@ -140,9 +140,8 @@ export const decodeEthereumDefinition = ( | |||
| */ | |||
| export const ethereumNetworkInfoFromDefinition = ( | |||
| definition: EthereumNetworkDefinitionDecoded, | |||
| ): EthereumNetworkInfo => ({ | |||
There was a problem hiding this comment.
on line 139, comment does not match anymore. nitpick
There was a problem hiding this comment.
I think I don't like the EthereumNetworkInfoDefinition type name. This utility is called ethereumNetworkInfoFromDefinition (as it would expect EthereumNetworkInfoDefinition as argument but it actually returns it
There was a problem hiding this comment.
Updated to EthereumNetworkInfoDefinitionValues.
mroz22
approved these changes
Jan 2, 2025
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12582348225 |
trezor-ci
force-pushed
the
feat/allow-lower-gas-price
branch
from
0b628a5 to
dcc62ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #15816
Resolve #15890
Screenshots: