Mobile - Solana send polishing #15957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vytick
commented
Dec 13, 2024
vytick
commented
- Remove unused thunk
- Fetch for Solana updates to better estimate fees already on outputs screen
|
🚀 Expo preview is ready!
|
PeKne
reviewed
Dec 13, 2024
matejkriz
reviewed
Dec 13, 2024
| }; | ||
| } | ||
| }, [account]); | ||
| useSubscribeForSolanaBlockUpdates(account); |
There was a problem hiding this comment.
SendOutputsScreen is not unmounted when SendFeesScreen is active, so the subscription is already active here, is that intentional? I guess it's not a problem and probably a bit safer to subscribe on both screens, but if you remove it from here, it should still works the same.
There was a problem hiding this comment.
@PeKne Mentioned the same thing. The intention was to make it work when coming to fee screen via different flow (trade), without specifying txn outputs.
I'll revisit this once more with other things we discussed
vytick
commented
Dec 13, 2024
| @@ -210,7 +213,8 @@ export const SendOutputsScreen = ({ | |||
| setValue('rippleDestinationTag', sendFormDraft.rippleDestinationTag, { | |||
| shouldTouch: true, | |||
| }); | |||
| await calculateNormalFeeMaxAmount(); | |||
| // The max amount is equal to the total token balance for tokens. (fee is paid in mainnet currency) | |||
There was a problem hiding this comment.
calculations for max should not be done in case tokens are sent. This will cause error at least on solana
vytick
force-pushed
the
feat/native/solana-send-tweaking
branch
from
db7b7ff to
267d655
Compare
PeKne
approved these changes
Dec 17, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12373007679 |
trezor-ci
force-pushed
the
feat/native/solana-send-tweaking
branch
from
267d655 to
ee7a2a8
Compare
|
Fingerprint is changed, new EAS Build(s) are now in pipeline. Build with commit ee7a2a8
Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "contents",
"id": "expoConfig",
"contents": "{\"android\":{\"adaptiveIcon\":{\"backgroundColor\":\"#E59D17\",\"foregroundImage\":\"./assets/appIcon_android.png\",\"monochromeImage\":\"./assets/appIcon_android.png\"},\"intentFilters\":[{\"action\":\"VIEW\",\"autoVerify\":true,\"category\":[\"BROWSABLE\",\"DEFAULT\"],\"data\":[{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/.*/deeplink/.*\",\"scheme\":\"https\"},{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/deeplink/.*\",\"scheme\":\"https\"}]}],\"package\":\"io.trezor.suite.preview\",\"permissions\":[\"android.permission.CAMERA\"]},\"androidStatusBar\":{\"backgroundColor\":\"#25292E\"},\"extra\":{\"commitHash\":\"b03b6c346123586ff52ef036b9135f6094cab3bf\",\"eas\":{\"projectId\":\"15998f8a-e75c-4b60-959d-6f68e5ff4936\"}},\"ios\":{\"associatedDomains\":[\"applinks:dev.suite.sldev.cz\"],\"bundleIdentifier\":\"io.trezor.suite.preview\",\"icon\":\"./assets/preview/appIcon.png\",\"infoPlist\":{\"ITSAppUsesNonExemptEncryption\":false,\"NSAppTransportSecurity\":{\"NSAllowsArbitraryLoads\":true,\"NSExceptionDomains\":{\"data.trezor.io\":{\"NSExceptionAllowsInsecureHTTPLoads\":true,\"NSIncludesSubdomains\":true},\"localhost\":{\"NSExceptionAllowsInsecureHTTPLoads\":true}}},\"NSCameraUsageDescription\":\"$(PRODUCT_NAME) needs access to your Camera to scan your XPUB.\",\"NSFaceIDUsageDescription\":\"$(PRODUCT_NAME) needs Face ID and Touch ID to keep sensitive data about your portfolio private.\",\"NSMicrophoneUsageDescription\":\"This app does not require access to the microphone.\",\"UIRequiredDeviceCapabilities\":[\"armv7\"]},\"supportsTablet\":true},\"name\":\"Trezor Suite Lite Preview\",\"orientation\":\"portrait\",\"owner\":\"trezorcompany-develop\",\"platforms\":[\"android\",\"ios\"],\"plugins\":[\"./plugins/withGradleProperties.js\",\"./plugins/withRemoveXcodeLocalEnv.js\",\"./plugins/withRemoveiOSNotificationEntitlement.js\",\"@trezor/react-native-usb/plugins/withUSBDevice.js\",[\"./plugins/withAndroidMainActivityAttributes.js\",{\"android:allowBackup\":false}],[\"@config-plugins/detox\",{\"subdomains\":\"*\"}],[\"@sentry/react-native/expo\",{\"organization\":\"satoshilabs\",\"project\":\"suite-native\",\"url\":\"https://sentry.io/\"}],[\"expo-build-properties\",{\"android\":{\"kotlinVersion\":\"1.9.24\",\"minSdkVersion\":28},\"ios\":{\"deploymentTarget\":\"15.1\"}}],[\"expo-camera\",{\"cameraPermission\":\"Allow $(PRODUCT_NAME) to access camera for QR code scanning.\",\"microphonePermission\":false,\"recordAudioAndroid\":false}],[\"expo-font\",{\"fonts\":[\"../../packages/theme/fonts/TTSatoshi-DemiBold.otf\",\"../../packages/theme/fonts/TTSatoshi-Medium.otf\",\"../../suite-common/icons/iconFontsMobile/TrezorSuiteIcons.ttf\"]}],[\"expo-image-picker\",{\"microphonePermission\":false,\"photosPermission\":\"Allow $(PRODUCT_NAME) to access your photos to let you import QR code images.\"}],[\"expo-splash-screen\",{\"backgroundColor\":\"#25292E\",\"dark\":{\"backgroundColor\":\"#25292E\",\"image\":\"./assets/splash_icon.png\"},\"image\":\"./assets/splash_icon.png\",\"imageWidth\":\"200\"}],[\"expo-video\"]],\"runtimeVersion\":\"21\",\"scheme\":\"trezorsuitelite\",\"sdkVersion\":\"52.0.0\",\"slug\":\"trezor-suite-preview\",\"updates\":{\"requestHeaders\":{\"expo-channel-name\":\"preview\"},\"url\":\"https://u.expo.dev/15998f8a-e75c-4b60-959d-6f68e5ff4936\"},\"userInterfaceStyle\":\"automatic\",\"version\":\"24.12.2\"}",
"reasons": [
"expoConfig"
],
"hash": "08bbf2b51021520c387b9056db05f0e274ea147b"
},
"afterSource": {
"type": "contents",
"id": "expoConfig",
"contents": "{\"android\":{\"adaptiveIcon\":{\"backgroundColor\":\"#E59D17\",\"foregroundImage\":\"./assets/appIcon_android.png\",\"monochromeImage\":\"./assets/appIcon_android.png\"},\"intentFilters\":[{\"action\":\"VIEW\",\"autoVerify\":true,\"category\":[\"BROWSABLE\",\"DEFAULT\"],\"data\":[{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/.*/deeplink/.*\",\"scheme\":\"https\"},{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/deeplink/.*\",\"scheme\":\"https\"}]}],\"package\":\"io.trezor.suite.preview\",\"permissions\":[\"android.permission.CAMERA\"]},\"androidStatusBar\":{\"backgroundColor\":\"#25292E\"},\"extra\":{\"commitHash\":\"7718d2b7a02321714f081b81f851ec6c3052ee4f\",\"eas\":{\"projectId\":\"15998f8a-e75c-4b60-959d-6f68e5ff4936\"}},\"ios\":{\"associatedDomains\":[\"applinks:dev.suite.sldev.cz\"],\"bundleIdentifier\":\"io.trezor.suite.preview\",\"icon\":\"./assets/preview/appIcon.png\",\"infoPlist\":{\"ITSAppUsesNonExemptEncryption\":false,\"NSAppTransportSecurity\":{\"NSAllowsArbitraryLoads\":true,\"NSExceptionDomains\":{\"data.trezor.io\":{\"NSExceptionAllowsInsecureHTTPLoads\":true,\"NSIncludesSubdomains\":true},\"localhost\":{\"NSExceptionAllowsInsecureHTTPLoads\":true}}},\"NSCameraUsageDescription\":\"$(PRODUCT_NAME) needs access to your Camera to scan your XPUB.\",\"NSFaceIDUsageDescription\":\"$(PRODUCT_NAME) needs Face ID and Touch ID to keep sensitive data about your portfolio private.\",\"NSMicrophoneUsageDescription\":\"This app does not require access to the microphone.\",\"UIRequiredDeviceCapabilities\":[\"armv7\"]},\"supportsTablet\":true},\"name\":\"Trezor Suite Lite Preview\",\"orientation\":\"portrait\",\"owner\":\"trezorcompany-develop\",\"platforms\":[\"android\",\"ios\"],\"plugins\":[\"./plugins/withGradleProperties.js\",\"./plugins/withRemoveXcodeLocalEnv.js\",\"./plugins/withRemoveiOSNotificationEntitlement.js\",\"@trezor/react-native-usb/plugins/withUSBDevice.js\",[\"./plugins/withAndroidMainActivityAttributes.js\",{\"android:allowBackup\":false}],[\"@config-plugins/detox\",{\"subdomains\":\"*\"}],[\"@sentry/react-native/expo\",{\"organization\":\"satoshilabs\",\"project\":\"suite-native\",\"url\":\"https://sentry.io/\"}],[\"expo-build-properties\",{\"android\":{\"kotlinVersion\":\"1.9.24\",\"minSdkVersion\":28},\"ios\":{\"deploymentTarget\":\"15.1\"}}],[\"expo-camera\",{\"cameraPermission\":\"Allow $(PRODUCT_NAME) to access camera for QR code scanning.\",\"microphonePermission\":false,\"recordAudioAndroid\":false}],[\"expo-font\",{\"fonts\":[\"../../packages/theme/fonts/TTSatoshi-DemiBold.otf\",\"../../packages/theme/fonts/TTSatoshi-Medium.otf\",\"../../suite-common/icons/iconFontsMobile/TrezorSuiteIcons.ttf\"]}],[\"expo-image-picker\",{\"microphonePermission\":false,\"photosPermission\":\"Allow $(PRODUCT_NAME) to access your photos to let you import QR code images.\"}],[\"expo-splash-screen\",{\"backgroundColor\":\"#25292E\",\"dark\":{\"backgroundColor\":\"#25292E\",\"image\":\"./assets/splash_icon.png\"},\"image\":\"./assets/splash_icon.png\",\"imageWidth\":\"200\"}],[\"expo-video\"]],\"runtimeVersion\":\"21\",\"scheme\":\"trezorsuitelite\",\"sdkVersion\":\"52.0.0\",\"slug\":\"trezor-suite-preview\",\"updates\":{\"requestHeaders\":{\"expo-channel-name\":\"preview\"},\"url\":\"https://u.expo.dev/15998f8a-e75c-4b60-959d-6f68e5ff4936\"},\"userInterfaceStyle\":\"automatic\",\"version\":\"24.12.2\"}",
"reasons": [
"expoConfig"
],
"hash": "48a35c5443c017006fd557932da57ba2902f10dc"
}
}
]
|
|
@STew790 Please, just try, that Solana send works as before. There is no big change, but better to test once more. |
|
QA OK SOL sent Info:
|
|
QA OK Info 25.1.2 30b62f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.